First ECAL implementation#120
Conversation
|
Hi @kharlov please trigger me when you need to have this PR reviewed |
|
Hi @njacazio , I fixed several bugs in ECAL response, please check and merge the new PR. |
| const double Bz = 5.e-1; | ||
| // TOF | ||
| const double tof_radius = 100.; // [cm] Radius of the TOF detector (used to compute acceptance) | ||
| const double tof_length = 200.; // [cm] Length of the TOF detector (used to compute acceptance) | ||
| const double tof_sigmat = 0.02; // [ns] Resolution of the TOF detector | ||
| const double tof_sigmat0 = 0.2; // [ns] Time spread of the vertex | ||
| const double tof_radius = 100.; | ||
| const double tof_length = 200.; | ||
| const double tof_sigmat = 0.020; | ||
| const double tof_sigmat0 = 0.20; |
There was a problem hiding this comment.
This should not need to be changed
| // Simulation parameters | ||
| constexpr bool do_vertexing = true; // Vertexing with the O2 | ||
| constexpr bool enable_nuclei = true; // Nuclei LUTs | ||
| constexpr bool enable_nuclei = true; |
There was a problem hiding this comment.
This should not need to be changed
| // info for the ECAL | ||
| float posZ, posPhi; | ||
| TLorentzVector pECAL; | ||
| if (ecal_detector.makeSignal(*particle, pECAL, posZ, posPhi)) { // to be updated 13.09.2021 |
There was a problem hiding this comment.
The initalization of the TLorentzVector could be done once and used outside of the loop for tracks
|
Also, there are some conflicts that have to solved before this can be merged |
|
Hi @njacazio , I solved conflicts, ran clang and opened a new PR. Did I do it correctly? |
|
Hi Yuri, yes, I will have a look asap |
|
Hi @njacazio , I fixed one more bug in ECAL response: photon hit coordinate was not calculated correctly. |
|
Hi, @kharlov, perfect, I will include it in the software as soon as you push it in this PR |
|
Ah, I just saw that you already did, I will import it now |
|
Closing as already merged in other PR |
2 participants
No description provided.